Remove ineffective argument from sample #131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the documentation of the individual env vars, `OVERPASS_META` only applies on `init` mode. Since this docker run example is using the `clone` mode the `OVERPASS_META` is ineffective and only makes the sample more complex and confusing.
|
|
|
Oh, I forgot to think about the update the script. Line 8 in b40e832 Based on the @wiktorn thx for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the documentation of the individual env vars,
OVERPASS_METAonly applies oninitmode. Since this docker run example is using theclonemode theOVERPASS_METAis ineffective and only makes the sample more complex and confusing.